Re: pgbench - allow backslash-continuations in custom scripts

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>
Cc: coelho(at)cri(dot)ensmp(dot)fr, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pgbench - allow backslash-continuations in custom scripts
Date: 2016-01-26 13:21:49
Message-ID: CAB7nPqRtaz2nGb-7wQJ+w1-rFyFFxkruesNBM3RcPCgXaCoSmQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Jan 26, 2016 at 6:51 PM, Kyotaro HORIGUCHI
<horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> wrote:
> Mmm. I believed that this is on CF app..
>
> At Tue, 19 Jan 2016 15:41:54 +0900, Michael Paquier <michael(dot)paquier(at)gmail(dot)com> wrote in <CAB7nPqQFnORG=LjDiGgD_hy_M00scx1ihn89QHx_1B9+3Vz7tQ(at)mail(dot)gmail(dot)com>
>> On Thu, Jan 7, 2016 at 5:36 PM, Kyotaro HORIGUCHI
>> <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> wrote:
>> > Finally, PsqlScanState has four callback funcions and all pgbench
>> > needs to do to use it is setting NULL to all of them and link the
>> > object file in psql directory. No link switch/ifdef are necessary.
>>
>> Am I missing something? This patch is not registered in the CF app.
>> Horiguchi-san, if you expect feedback, it would be good to get it
>> there.
>
> Thank you very much Michael but the CF app doesn't allow me to
> regsiter new one.

That's perhaps a bit late I am afraid for this CF, we are at the end
of January already...

> Filling the Description field with "pgbench -
> allow backslash-continuations in custom scripts" and chose a
> topic then "Find thread" shows nothing. Filling the search text
> field on the "Attach thread" dialogue with the description or
> giving the exact message-id gave me nothing to choose.

Really? That's because the patch is marked as returned with feedback here:
https://commitfest.postgresql.org/7/319/

> Maybe should I repost the patch so that the "Attach thread" can
> find it as a "recent" email?

What if you just add it to next CF with a new entry? You are actually
proposing an entirely new patch.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2016-01-26 13:25:56 Re: Improve tab completion for REFRESH MATERIALIZED VIEW
Previous Message Pavel Stehule 2016-01-26 13:13:09 Re: custom function for converting human readable sizes to bytes