From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
---|---|
To: | PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Incorrect comment in 001_ssltests.pl |
Date: | 2017-06-16 23:53:41 |
Message-ID: | CAB7nPqRrh9YeHzOBKUanB7ONxCOZS3suiZGyYnoYSK7FK_N7mg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi all,
I have noticed the following thing:
--- a/src/test/ssl/t/001_ssltests.pl
+++ b/src/test/ssl/t/001_ssltests.pl
@@ -34,8 +34,6 @@ sub run_test_psql
# The first argument is a (part of a) connection string, and it's also printed
# out as the test case name. It is appended to $common_connstr global variable,
# which also contains a libpq connection string.
-#
-# The second argument is a hostname to connect to.
sub test_connect_ok
{
my $connstr = $_[0]
But test_connect_ok and test_connect_fails do not have a second
argument as the hostname is appended directly into $common_connstr.
(I am thinking as well that run_test_psql, test_connect_ok and
test_connect_fails ought to be moved to ServerSetup.pm so as other SSL
tests can take advantage of them, but that's another story for another
day.)
Thanks,
--
Michael
Attachment | Content-Type | Size |
---|---|---|
ssl-test-typo.patch | text/x-patch | 536 bytes |
From | Date | Subject | |
---|---|---|---|
Next Message | Stephen Frost | 2017-06-17 00:20:25 | Re: RLS policy not getting honer while pg_dump on declarative partition |
Previous Message | Piotr Stefaniak | 2017-06-16 22:52:53 | Re: Preliminary results for proposed new pgindent implementation |