From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
---|---|
To: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> |
Cc: | Andres Freund <andres(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: pg_rewind in contrib |
Date: | 2014-12-16 01:26:50 |
Message-ID: | CAB7nPqRoV_kG4xJaNLNuttWcMyrTb4-yQORs3JuYF0JESNnsOg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, Dec 16, 2014 at 9:32 AM, Michael Paquier
<michael(dot)paquier(at)gmail(dot)com> wrote:
> On Sat, Dec 13, 2014 at 12:01 AM, Heikki Linnakangas
> <hlinnakangas(at)vmware(dot)com> wrote:
>> On 12/12/2014 04:20 PM, Andres Freund wrote:
>>>
>>> Not sure if the copyright notices in the current form are actually ok?
>>
>>
>> Hmm. We do have such copyright notices in the source tree, but I know that
>> we're trying to avoid it in new code. They had to be there when the code
>> lived as a separate project, but now that I'm contributing this to
>> PostgreSQL proper, I can remove them if necessary.
> Yep, it is fine to remove those copyright notices and to keep only the
> references to PGDG when code is integrated in the tree.
In any case, I have a couple of comments about this patch as-is:
- If the move to src/bin is done, let's update the MSVC scripts accordingly
- contrib/pg_rewind/.gitignore should be cleaned up from its unnecessary entries
- README is incorrect, it is still mentioned for example that this
code should be copied inside PostgreSQL code tree as contrib/pg_rewind
- Code is going to need a brush to clean up things of this type:
--
Michael
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2014-12-16 01:38:27 | Re: pg_rewind in contrib |
Previous Message | Jim Nasby | 2014-12-16 01:23:39 | Re: Fractions in GUC variables |