| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | hlinnaka(at)iki(dot)fi |
| Cc: | Vladimir Borodin <root(at)simply(dot)name>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Broken --dry-run mode in pg_rewind |
| Date: | 2015-05-08 12:39:10 |
| Message-ID: | CAB7nPqRkgd2sc2JS_MYyz1ucdB=idB+o+M5c1LZgYjMKjufr1g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, May 8, 2015 at 9:34 PM, Heikki Linnakangas <hlinnaka(at)iki(dot)fi> wrote:
> On 05/08/2015 03:25 PM, Vladimir Borodin wrote:
>> Seems, that pg_rewind does not account --dry-run option properly. A simple
>> fix
>> for that is attached.
>
>
> No, the --dry-run takes effect later. It performs all the actions it
> normally would, including reading files from the source, except for actually
> writing anything in the target. See the dry-run checks in file_ops.c
Even if the patch sent is incorrect, shouldn't there be some process
bypass in updateControlFile() and createBackupLabel() in case of a
--dry-run?
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2015-05-08 12:55:05 | Re: Broken --dry-run mode in pg_rewind |
| Previous Message | Heikki Linnakangas | 2015-05-08 12:34:19 | Re: Broken --dry-run mode in pg_rewind |