| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Antonin Houska <ah(at)cybertec(dot)at> |
| Cc: | Oleg Ivanov <o(dot)ivanov(at)postgrespro(dot)ru>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] Proposal: generic WAL compression |
| Date: | 2017-11-30 02:40:09 |
| Message-ID: | CAB7nPqRhguGfRjMdXntB1Qo5ELonHdBeNoDm67fm0o96EkjG2Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Nov 20, 2017 at 4:49 PM, Antonin Houska <ah(at)cybertec(dot)at> wrote:
> One more idea:
>
> I think the metadata (ALIGN_GAP) should be stored separate from the actual
> data so that you can use memcpy() instead of this loop:
>
> while (i < j)
> {
> char c = targetRegionAligned[i++];
>
> writeToPtr(ptr, c);
> }
Moved to next CF per lack of reviews. The patch still applies.
Oleg, I would recommend as well that you do more patch reviews. Let's
not forget that for one patch submitted you should review one patch
with a somewhat equal difficulty, and yours is quite specialized.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2017-11-30 02:41:58 | Re: [HACKERS] Removing LEFT JOINs in more cases |
| Previous Message | Michael Paquier | 2017-11-30 02:37:38 | Re: [HACKERS] PATCH: enabling parallel execution for cursors explicitly (experimental) |