From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
---|---|
To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Re: [COMMITTERS] pgsql: Windows: Make pg_ctl reliably detect service status |
Date: | 2016-01-08 00:04:45 |
Message-ID: | CAB7nPqResj56HjnT1awd6QFDUva0V5XJXq8ft6i3Jr6vPxdy1g@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
On Fri, Jan 8, 2016 at 8:38 AM, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> wrote:
> Tom Lane wrote:
>> Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
>> > I confirmed that adding that line makes the new file get compiled. I
>> > also noticed these warnings when compiling it:
>>
>> > In file included from /usr/lib/gcc/x86_64-w64-mingw32/4.9-win32/include/stdarg.h:1:0,
>> > from /pgsql/source/master/src/include/c.h:85,
>> > from /pgsql/source/master/src/include/postgres_fe.h:25,
>> > from /pgsql/source/master/src/port/win32security.c:17:
>> > /pgsql/source/master/src/port/win32security.c: In function ‘log_error’:
>> > /pgsql/source/master/src/port/win32security.c:37:11: warning: passing argument 1 of ‘__builtin_va_start’ from incompatible pointer type
>> > va_start(fmt, ap);
>> > ^
>>
>> I take it this code is quite untested, because what that's whining
>> about is that the arguments of va_start() are reversed.
>
> It is untested by me, yes. Pushed a fix for this problem.
Arg, thanks! My MS 2010 compiler did not complain about that. That's a
bit depressing...
--
Michael
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2016-01-08 01:32:43 | pgsql: Delay creation of subplan tlist until after create_plan(). |
Previous Message | Alvaro Herrera | 2016-01-07 23:38:51 | Re: Re: [COMMITTERS] pgsql: Windows: Make pg_ctl reliably detect service status |
From | Date | Subject | |
---|---|---|---|
Next Message | chris | 2016-01-08 00:25:26 | BUG #13854: SSPI authentication failure: wrong realm name used |
Previous Message | Alvaro Herrera | 2016-01-07 23:58:25 | Re: Very confusing installcheck behavior with PGXS |