From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
---|---|
To: | Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi> |
Cc: | pgsql-committers(at)postgresql(dot)org |
Subject: | Re: pgsql: Fix two bugs in tsquery @> operator. |
Date: | 2014-10-27 10:24:01 |
Message-ID: | CAB7nPqRcaCwafnBfipKzfcsezNa-jYuOhg7kBQQ+hLxjQ6CxzA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
On Mon, Oct 27, 2014 at 5:52 PM, Heikki Linnakangas
<heikki(dot)linnakangas(at)iki(dot)fi> wrote:
> Fix two bugs in tsquery @> operator.
>
> 1. The comparison for matching terms used only the CRC to decide if there's
> a match. Two different terms with the same CRC gave a match.
>
> 2. It assumed that if the second operand has more terms than the first, it's
> never a match. That assumption is bogus, because there can be duplicate
> terms in either operand.
>
> Rewrite the implementation in a way that doesn't have those bugs.
>
> Backpatch to all supported versions.
Perhaps the CRC implementation would change in the future, but what
about adding regression tests as well? Those are still bugs.
--
Michael
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2014-10-27 15:12:14 | pgsql: Add missing equals signs to pg_recvlogical documentation. |
Previous Message | Heikki Linnakangas | 2014-10-27 08:52:26 | pgsql: Fix two bugs in tsquery @> operator. |