| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql: Provide overflow safe integer math inline functions. |
| Date: | 2017-12-18 00:20:39 |
| Message-ID: | CAB7nPqR_N2OpU2U4UR_Ydttqr1GxVCQGfsi_R_5eYnisay5C8w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Mon, Dec 18, 2017 at 1:03 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Michael Paquier <michael(dot)paquier(at)gmail(dot)com> writes:
>> ... Please note that if you added
>> a volatile cast to "result" as well, then compilation was able to
>> complete and regression tests passed...
>
> Yeah, that squares with my analysis: the problem with the existing test
> is that the compiler is throwing away the function call because its
> output is unused.
>
> If I haven't seen something from Andres shortly, I'll push a fix.
And the buildfarm is happy again. Thanks for the fix.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2017-12-18 10:25:26 | pgsql: Fix typo on comment |
| Previous Message | Tom Lane | 2017-12-17 17:02:18 | Re: pgsql: Use new overflow aware integer operations. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2017-12-18 00:23:45 | Re: Protect syscache from bloating with negative cache entries |
| Previous Message | Thomas Munro | 2017-12-17 22:29:38 | Re: [sqlsmith] Parallel worker executor crash on master |