Re: Let file_fdw access COPY FROM PROGRAM

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Craig Ringer <craig(dot)ringer(at)2ndquadrant(dot)com>
Cc: Corey Huinker <corey(dot)huinker(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>
Subject: Re: Let file_fdw access COPY FROM PROGRAM
Date: 2016-09-06 23:29:57
Message-ID: CAB7nPqRVMLvyQm2NJMvLZcG996=Qu_vJDYA_V8Ctrt0wr7VvSA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Sep 7, 2016 at 7:53 AM, Craig Ringer
<craig(dot)ringer(at)2ndquadrant(dot)com> wrote:
> On 7 Sep. 2016 02:14, "Corey Huinker" <corey(dot)huinker(at)gmail(dot)com> wrote:
>>
>
>> Having regression tests for this is extremely problematic, because the
>> program invoked would need to be an invokable command on any architecture
>> supported by postgres. I'm pretty sure no such command exists.
>
> Your best bet will be using the TAP framework. There you can use Perl logic.
>
> I'm not sure where to put such a test though. It doesn't really make sense
> in src/test/recovery/ .

There is nothing preventing the addition of a TAP test where there are
normal regression tests, so if you want a test for file_fdw you should
add it there, then change its Makefile to have the following target
rules:
check: prove-check

prove-check:
$(prove_check)
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Claudio Freire 2016-09-06 23:55:09 Re: Parallel tuplesort (for parallel B-Tree index creation)
Previous Message Peter Geoghegan 2016-09-06 23:28:47 Re: Parallel tuplesort (for parallel B-Tree index creation)