| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | David Steele <david(at)pgmasters(dot)net> |
| Cc: | Venkata B Nagothi <nag1010(at)gmail(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: patch proposal |
| Date: | 2017-01-24 03:52:10 |
| Message-ID: | CAB7nPqRVCH95MQ8dQgCrRzQmwiX=dKDKyKYYVW=hj7YMM6r=wA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jan 24, 2017 at 7:22 AM, David Steele <david(at)pgmasters(dot)net> wrote:
> 3) There are no tests. I believe that
> src/test/recovery/t/006_logical_decoding.pl would be the best place to
> insert your tests.
003_recovery_targets.pl is the test for recovery targets. The routines
it has would be helpful.
> I'm marking this as "Waiting on Author", but honestly I think "Returned
> with Feedback" might be more appropriate. I'll leave that up to the CFM.
We could wait a couple of days before that, this patch just got a
review. (Thanks!)
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2017-01-24 03:59:44 | Re: src/test/README for logical replication |
| Previous Message | Tom Lane | 2017-01-24 03:49:42 | Re: Checksums by default? |