From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
---|---|
To: | Ryan Murphy <ryanfmurphy(at)gmail(dot)com> |
Cc: | PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>, Pierre Ducroquet <p(dot)psql(at)pinaraf(dot)info> |
Subject: | Re: Small patch for pg_basebackup argument parsing |
Date: | 2017-07-05 06:32:36 |
Message-ID: | CAB7nPqRSNHVPYGbhwEAGj5R1xrfE=qY2MLY9gNFQwRMmz7Ob0w@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Jul 5, 2017 at 2:57 PM, Ryan Murphy <ryanfmurphy(at)gmail(dot)com> wrote:
> I tried to apply your patch to test it (though reading Robert's last comment it seems we wish to have it adjusted before committing)... but in any case I was not able to apply your patch to the tip of the master branch (my git apply failed). I'm setting this to Waiting On Author for a new patch, and I also agree with Robert that the test can be simpler and can go in the other order. If you don't have time to make another patch, let me know, I may be able to make one.
git is unhappy even if forcibly applied with patch -p1. You should
check for whitespaces at the same time:
$ git diff --check
src/bin/pg_basebackup/pg_receivewal.c:483: indent with spaces.
+ char *strtol_endptr = NULL
And there are more than this one.
--
Michael
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2017-07-05 07:57:20 | Re: pg_stop_backup(wait_for_archive := true) on standby server |
Previous Message | Michael Paquier | 2017-07-05 06:28:52 | Re: Extra Vietnamese unaccent rules |