Re: make pg_controldata accept "-D dirname"

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>
Cc: Abhijit Menon-Sen <ams(at)2ndquadrant(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: make pg_controldata accept "-D dirname"
Date: 2014-10-26 04:34:44
Message-ID: CAB7nPqRRxweoyhq7xBXOg2ORrP-WPvJJDkGTEOW-FDGcc8BG=Q@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Oct 25, 2014 at 1:20 AM, Heikki Linnakangas
<hlinnakangas(at)vmware(dot)com> wrote:
> Argh, looks like I forgot the actual code changes required.
> I just noticed that pg_controldata and pg_resetxlog don't check for extra
> arguments:
> $ pg_resetxlog data fds sdf sdf
> Transaction log reset
I think that it would be good to add as well a set of TAP tests for
all those things. So attached are two patches, one to complete the
tests of pg_controldata, and a second one to add TAP tests for
pg_resetxlog.
--
Michael

Attachment Content-Type Size
0001-Add-more-TAP-tests-for-pg_controldata.patch text/x-diff 1.6 KB
0002-Add-TAP-tests-for-pg_resetxlog.patch text/x-diff 2.4 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Haribabu Kommi 2014-10-26 05:12:06 Re: Index scan optimization
Previous Message Doyle, Bryan 2014-10-26 02:51:50 Re: PostgreSQL Service Name Enhancement - Wildcard support for LDAP/DNS lookup