| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Andreas Karlsson <andreas(at)proxel(dot)se> |
| Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: COPY (... tab completion |
| Date: | 2016-01-19 12:00:08 |
| Message-ID: | CAB7nPqRQvKxbrr1qnwxdz6FOkx_5ffQ3dySxffF_Af4o70J4Mw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jan 19, 2016 at 8:00 PM, Andreas Karlsson <andreas(at)proxel(dot)se> wrote:
> On 01/19/2016 07:55 AM, Michael Paquier wrote:
>>
>> + /* If we have COPY BINARY, compelete with list of tables */
>> s/compelete/complete
>
> Fixed.
>
>> + else if (TailMatches2("COPY|\\copy", "("))
>> + COMPLETE_WITH_LIST7("SELECT", "TABLE", "VALUES", "INSERT",
>> "UPDATE", "DELETE", "WITH");
>> This one should be Matches, no?
>
> Yep, fixed.
Marked as ready for committer.
This patch makes me wonder: are we going to nuke the grammar "COPY [
BINARY ] table_name" at some point? This was used up to 7.3.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Kellerer | 2016-01-19 12:07:55 | Re: Window2012R2: initdb error: "The current directory is invalid." |
| Previous Message | Andreas Karlsson | 2016-01-19 11:00:25 | Re: COPY (... tab completion |