| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Specifying the unit in storage parameter |
| Date: | 2014-08-28 03:55:46 |
| Message-ID: | CAB7nPqRNvoqxbgu=B_RfJL-K0zYrAQPH++s_DKpdGwP+dErWQA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Aug 27, 2014 at 10:59 PM, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
wrote:
> Not necessarily, because it's harmless. It's there for purely
> aesthetical reasons, so it's your choice whether to add it or not.
> Having it there is slightly easier on somebody reading the code,
> perhaps.
On my side, that's up to you Fujii-san. The patch does what it states, I
only think that this extra 0 should be added either everywhere or nowhere.
Not mandatory either: drop test_param_unit in the regression tests after
running the test queries.
Regards,
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2014-08-28 03:58:44 | Re: [TODO] Track number of files ready to be archived in pg_stat_archiver |
| Previous Message | Peter Geoghegan | 2014-08-28 02:43:44 | INSERT ... ON CONFLICT {UPDATE | IGNORE} |