From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
---|---|
To: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> |
Cc: | PostgreSQL mailing lists <pgsql-odbc(at)postgresql(dot)org> |
Subject: | Re: Regression tests for deprecated functions |
Date: | 2014-03-20 00:45:36 |
Message-ID: | CAB7nPqRMuJvUVb4BjuW_TUhvQOy0DnaZhQxr96Ar8ssej9a6ng@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-odbc |
Updated patch is attached.
On Thu, Mar 20, 2014 at 9:15 AM, Heikki Linnakangas
<hlinnakangas(at)vmware(dot)com> wrote:
> On 03/19/2014 01:27 PM, Michael Paquier wrote:
>>
>> I have created the attached patch, that adds a new set of regression
>> tests for all the deprecated functions of ODBC listed here:
>> http://msdn.microsoft.com/en-us/library/ms716309%28v=vs.85%29.aspx
>
>
> SQLFreeStmt isn't completely deprecated, just the SQL_DROP option. Which
> you're not testing ;-).
Oops. It looks like a typo. I changed the test to use SQL_DROP.
> SQLBindParam isn't really deprecated, see
> http://msdn.microsoft.com/en-us/library/ms710955%28v=vs.85%29.aspx. I think
> we'll want to keep that, even if we remove the rest of the deprecated
> functions, to stay compatible with a ISO / Open Group driver manager that
> doesn't know about the Microsoft extensions. (AFAIK no such driver manager
> actually exists, but as a matter of principle...)
OK, I thought so... Now test is removed.
> Please also add the new test case to test/Makefile and Makefile.am
Fixed.
Regards,
--
Michael
Attachment | Content-Type | Size |
---|---|---|
20140320_pgodbc_deprecated_v2.patch | text/plain | 11.6 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2014-03-20 05:24:47 | Re: Regression tests for deprecated functions |
Previous Message | Heikki Linnakangas | 2014-03-20 00:15:35 | Re: Regression tests for deprecated functions |