From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
---|---|
To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Several problems in tab-completions for SET/RESET |
Date: | 2016-01-29 04:02:20 |
Message-ID: | CAB7nPqRHRGNv9N9r6R2xCCjY5kcDSpap41FTBErSpWcOv7HKtw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, Jan 29, 2016 at 11:53 AM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
> I removed the above and added the following for that case.
>
> + /* Complete ALTER DATABASE|FUNCTION|ROLE|USER ... SET <name> */
> + else if (Matches2("ALTER", "DATABASE|FUNCTION|ROLE|USER") &&
> + TailMatches2("SET", MatchAny))
> + COMPLETE_WITH_LIST2("FROM CURRENT", "TO");
>
> Attached is the updated version of the patch.
"ALTER FUNCTION foo(bar)" suggests OWNER TO, RENAME TO and SET SCHEMA.
I think that we had better suggesting SET instead of SET SCHEMA, and
add SCHEMA in the list of things suggested by SET.
"ALTER DATABASE foodb SET foo_param" should suggest TO/= but that's
not the case. After adding TO/= manually, a list of values is
suggested though. Same problem with ALTER ROLE and ALTER FUNCTION.
> I also added the change that Sawada suggested, to the patch.
OK.
--
Michael
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2016-01-29 04:07:36 | Re: Request - repeat value of \pset title during \watch interations |
Previous Message | Kouhei Kaigai | 2016-01-29 03:18:29 | Re: CustomScan in a larger structure (RE: CustomScan support on readfuncs.c) |