Re: Suggestion to improve select pg_reload_conf()

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Achilleas Mantzios <achill(at)matrix(dot)gatewaynet(dot)com>
Cc: PostgreSQL mailing lists <pgsql-general(at)postgresql(dot)org>
Subject: Re: Suggestion to improve select pg_reload_conf()
Date: 2017-04-03 08:12:29
Message-ID: CAB7nPqR3WP7G0zr1dgzT1O5Efm_h7Z9-Nf4LR3FOS3p1vFFyGQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general

On Mon, Apr 3, 2017 at 4:39 PM, Achilleas Mantzios
<achill(at)matrix(dot)gatewaynet(dot)com> wrote:
> On 03/04/2017 10:31, Thomas Kellerer wrote:
>>
>> I would like to suggest an improvement to the select pg_reload_conf()
>> function.
>>
>> Currently this will only return true or false indicating if reloading was
>> successful.
>>
>> I think it would be a "nice-to-have" if the function would also return the
>> GUCs that have been changed, similar to what is being written to the
>> logfile.
>>
>> To not break existing code (e.g. scripts that only expect true/false),
>> this could be done through an optional boolean parameter (e.g. named
>> "verbose").
>
> To my understanding pg_reload_conf just SIGHUP's the postmaster. So it might
> not be so trivial.

Yup. But there is a workaround possible at SQL-level to know what are
the parameters that would be updated on SIGHUP by comparing the values
in pg_file_settings that are the values found in the configuration
files with the current settings applied in pg_settings.
--
Michael

In response to

Browse pgsql-general by date

  From Date Subject
Next Message Tom DalPozzo 2017-04-03 09:40:29 spin locks and starvation
Previous Message Achilleas Mantzios 2017-04-03 07:39:30 Re: Suggestion to improve select pg_reload_conf()