| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Fabrízio Mello <fabriziomello(at)gmail(dot)com> |
| Cc: | PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: recovery_min_apply_delay with a negative value |
| Date: | 2015-01-03 12:59:06 |
| Message-ID: | CAB7nPqR3Cikw7uSmHkGxFby9m5Q8ymLGKeoOADzhMFNDO+2yzQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Dec 30, 2014 at 4:30 AM, Fabrízio de Royes Mello
<fabriziomello(at)gmail(dot)com> wrote:
>
>
> On Sun, Dec 28, 2014 at 12:31 PM, Michael Paquier
> <michael(dot)paquier(at)gmail(dot)com> wrote:
>>
>> Hi all,
>>
>> While reviewing another patch, I have noticed that
>> recovery_min_apply_delay can have a negative value. And the funny part is
>> that we actually attempt to apply a delay even in this case, per se this
>> condition recoveryApplyDelay(at)xlog(dot)c:
>> /* nothing to do if no delay configured */
>> if (recovery_min_apply_delay == 0)
>> return false;
>> Shouldn't we simply leave if recovery_min_apply_delay is lower 0, and not
>> only equal to 0?
>>
>
> Seems reasonable.
Trivial patch for master and REL9_4_STABLE attached as long as I don't
forget it..
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| 20150103_min_delay_negative_fix.patch | text/x-diff | 423 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2015-01-03 15:03:36 | Re: pg_basebackup -x/X doesn't play well with archive_mode & wal_keep_segments |
| Previous Message | Michael Paquier | 2015-01-03 12:54:16 | Updating copyright notices to 2015 for PGDG |