From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
---|---|
To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
Cc: | Julien Rouhaud <julien(dot)rouhaud(at)dalibo(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Noah Misch <noah(at)leadboat(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: split builtins.h to quote.h |
Date: | 2014-11-06 23:30:51 |
Message-ID: | CAB7nPqR2rFLCmrbJ_qB_=zD-56GHrT_Xm-Q_vROzQ=UzQJ7orQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, Nov 7, 2014 at 2:31 AM, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> wrote:
> Julien Rouhaud wrote:
>
>> I just reviewed this patch :
>>
>> * applies cleanly to master(d2b8a2c7)
>> * all regression tests pass
>>
>> As it's only moving functions from builtins.h to quote.h and update
>> impacted files, nothing special to add.
>>
>> It will probably break some user extensions using quote_* functions.
>> Otherwise it looks ready to commit.
>
> I thought the consensus was that the SQL-callable function declarations
> should remain in builtins.h -- mainly so that quote.h does not need to
> include fmgr.h.
Moving everything to quote.h is done in-line with what Tom and Robert
suggested, builtins.h being a refuge for function declarations that
have nowhere else to go. Suggestion from here:
http://www.postgresql.org/message-id/CA+TgmoZF3dkpTuA6Ex6gXLnnd-nMS-fBjCXRoiTwFfH-+6yBQQ@mail.gmail.com
--
Michael
From | Date | Subject | |
---|---|---|---|
Next Message | Greg Stark | 2014-11-06 23:40:18 | Re: Proposal: Log inability to lock pages during vacuum |
Previous Message | Peter Eisentraut | 2014-11-06 22:46:42 | Re: [PATCH] HINT: pg_hba.conf changed since last config reload |