Re: pgsql: Add GUC to enable compression of full page images stored in WAL.

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: Andres Freund <andres(at)2ndquadrant(dot)com>, Fujii Masao <fujii(at)postgresql(dot)org>, pgsql-committers <pgsql-committers(at)postgresql(dot)org>
Subject: Re: pgsql: Add GUC to enable compression of full page images stored in WAL.
Date: 2015-03-13 09:17:38
Message-ID: CAB7nPqR0azEgsE65kTYpOPziEm3NJyQKpWv3RpL3KhehKUPxHQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Thu, Mar 12, 2015 at 7:13 PM, Fujii Masao wrote:
> On Wed, Mar 11, 2015 at 11:30 PM, Michael Paquier wrote:
>> On Wed, Mar 11, 2015 at 11:18 PM, Andres Freund wrote:
>>> I've not checked whether they're spurious or not.
>
> Thanks for the report! We can suppress those warnings just by
> initializing cbimg.hole_length and hole_length. But I'd like to apply
> the attached patch which not only initializes the variable but also
> refactors the related code.

FWIW, I just had a look at this patch, and it looks good to me. Thanks!
--
Michael

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2015-03-13 12:02:10 pgsql: Document the new custom scan APIs.
Previous Message Tom Lane 2015-03-12 18:18:31 pgsql: Improve documentation of bt_page_items().