From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
---|---|
To: | Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com> |
Cc: | nb <nbedxp(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: pg_basebackup fails on Windows when using tablespace mapping |
Date: | 2017-09-10 04:39:18 |
Message-ID: | CAB7nPqR0S_AAYS6ts1V34JUhN42jd0yQ+X=f+bhXBbb0Vvb4kQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Sun, Sep 10, 2017 at 12:28 PM, Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com> wrote:
> On Tue, Jun 27, 2017 at 6:36 PM, Michael Paquier
> <michael(dot)paquier(at)gmail(dot)com> wrote:
>> On Tue, Jun 27, 2017 at 7:46 PM, Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com> wrote:
>>> I am still seeing the issue with the attached patch. I had a quick
>>> look into the patch. It seems to me like you have canonicalized the
>>> tablespace path to convert win32 slashes to unix type of slashes but
>>> that is not being passed to strcmp() function and probably that could
>>> be the reason why the issue is still existing. Thanks.
>>>
>>> for (cell = tablespace_dirs.head; cell; cell = cell->next)
>>> - if (strcmp(dir, cell->old_dir) == 0)
>>> + if (strcmp(canon_dir, cell->old_dir) == 0)
>>
>> Thanks. I had the correct version on my Windows box actually, just
>> messed up the attachment.
>> --
>
> Okay. I have once again reviewed your patch and tested it on Windows
> as well as Linux. The patch LGTM. I am now marking it as Ready For
> Committer. Thanks.
Thanks for the review, Ashutosh.
--
Michael
From | Date | Subject | |
---|---|---|---|
Next Message | Jaime Casanova | 2017-09-10 05:08:58 | Re: generated columns |
Previous Message | Ashutosh Sharma | 2017-09-10 03:28:37 | Re: pg_basebackup fails on Windows when using tablespace mapping |