Re: [COMMITTERS] pgsql: Restart logical replication launcher when killed

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Restart logical replication launcher when killed
Date: 2017-06-21 23:46:35
Message-ID: CAB7nPqR=SYXnpkHLDUvViCcQHBSOe+YR=dHDsNu+HtsReuseUA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Thu, Jun 22, 2017 at 4:16 AM, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:
> Restart logical replication launcher when killed

- /* The logical replication launcher can be stopped at any time. */
- proc_exit(0);
+ /* The logical replication launcher can be stopped at any time.
+ * Use exit status 1 so the background worker is restarted. */
+ proc_exit(1);
I know I am noisy on the matter but... This comment format is not PG-like.
--
Michael

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2017-06-21 23:52:16 Re: [COMMITTERS] pgsql: Restart logical replication launcher when killed
Previous Message Andres Freund 2017-06-21 21:27:32 pgsql: Fix possibility of creating a "phantom" segment after promotion.

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2017-06-21 23:46:51 Re: RLS in CTE incorrect permission failure
Previous Message Craig Ringer 2017-06-21 23:44:03 Re: PATCH: Batch/pipelining support for libpq