Re: Enforce creation of destination folders for source files in pg_regress (Was: pg_regress writes into source tree)

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Enforce creation of destination folders for source files in pg_regress (Was: pg_regress writes into source tree)
Date: 2015-02-24 07:23:03
Message-ID: CAB7nPqR+A-KEK7dD8QXQszXCWiAj4_88btn0GywBZzpDnE1EKA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Feb 23, 2015 at 9:31 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:

>
> > On Feb 22, 2015, at 5:41 AM, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
> wrote:
> > This is up to the maintainer of each extension to manage their code
> > tree. However I can imagine that some people would be grateful if we
> > allow them to not need sql/ and expected/ containing only one single
> > .gitignore file ignoring everything with "*", making the code tree of
> > their extensions cleaner.
>
> I don't see this as an improvement. What's wrong with a .gitignore file
> ignoring everything?
>

That's mainly a matter of code maintenance style (and I am on the side that
a minimum number of folders in a git tree makes things easier to follow),
and IMO it is strange to not have some flexibility. Btw, the reason why
this patch exists is this thread of last December:
http://www.postgresql.org/message-id/flat/20141212134508(dot)GT1768(at)alvh(dot)no-ip(dot)org#20141212134508(dot)GT1768@alvh.no-ip.org
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2015-02-24 08:06:02 Re: improving speed of make check-world
Previous Message Michael Paquier 2015-02-24 07:03:41 Re: [REVIEW] Re: Compression of full-page-writes