Re: tracking commit timestamps

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Noah Misch <noah(at)leadboat(dot)com>
Cc: Petr Jelinek <petr(at)2ndquadrant(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Steve Singer <steve(at)ssinger(dot)info>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Andres Freund <andres(at)2ndquadrant(dot)com>, Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>, "Anssi K??ri?inen" <anssi(dot)kaariainen(at)thl(dot)fi>, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Jaime Casanova <jaime(at)2ndquadrant(dot)com>
Subject: Re: tracking commit timestamps
Date: 2014-12-15 08:12:10
Message-ID: CAB7nPqQxAc_nHOb_2SF+Nhz7CRc83QoZbhzBLH09GadxA-8OYg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-www

On Wed, Dec 10, 2014 at 6:50 PM, Noah Misch <noah(at)leadboat(dot)com> wrote:
> On Mon, Dec 08, 2014 at 02:23:39AM +0100, Petr Jelinek wrote:
>> On 08/12/14 00:56, Noah Misch wrote:
>> >The commit_ts test suite gives me the attached diff on a 32-bit MinGW build
>> >running on 64-bit Windows Server 2003. I have not checked other Windows
>> >configurations; the suite does pass on GNU/Linux.
>>
>> Hmm I wonder if "< now()" needs to be changed to "<= now()" in those queries
>> to make them work correctly on that plarform, I don't have machine with that
>> environment handy right now, so I would appreciate if you could try that, in
>> case you don't have time for that, I will try to setup something later...
>
> I will try that, though perhaps not until next week.

FWIW, I just tried that with MinGW-32 and I can see the error on Win7.
I also checked that changing "< now()" to "<= now()" fixed the
problem, so your assumption was right, Petr.
Regards,
--
Michael

Attachment Content-Type Size
20141215_committs_mingw_fix.patch application/octet-stream 2.2 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2014-12-15 08:14:37 Re: ctidscan as an example of custom-scan (Re: [v9.5] Custom Plan API)
Previous Message Kouhei Kaigai 2014-12-15 07:55:11 ctidscan as an example of custom-scan (Re: [v9.5] Custom Plan API)

Browse pgsql-www by date

  From Date Subject
Next Message Petr Jelinek 2014-12-15 08:41:36 Re: tracking commit timestamps
Previous Message Noah Misch 2014-12-11 02:50:53 Re: tracking commit timestamps