| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Cc: | "Bossart, Nathan" <bossartn(at)amazon(dot)com>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Subject: | Re: [Proposal] Allow users to specify multiple tables in VACUUM commands |
| Date: | 2017-09-05 03:24:37 |
| Message-ID: | CAB7nPqQuj+-dKuvPGG59yvD3MFqch1ewMNEi+LOC8LBwq5e7YA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Sep 5, 2017 at 12:05 PM, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
> In get_rel_oids() we often switch the memory context to vac_context
> and switch back. As a result almost code in get_rel_oids() is working
> in vac_context. Maybe we can switch memory context before and after
> the calling get_rel_oids?
I thought about that as well, and it seemed to me that the current
patch approach is less bug-prone for the future if get_rel_oids() gets
called in some future code paths.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Simon Riggs | 2017-09-05 03:32:12 | Re: [Proposal] Allow users to specify multiple tables in VACUUM commands |
| Previous Message | Masahiko Sawada | 2017-09-05 03:05:01 | Re: [Proposal] Allow users to specify multiple tables in VACUUM commands |