| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Strange assertion using VACOPT_FREEZE in vacuum.c |
| Date: | 2015-03-18 01:58:00 |
| Message-ID: | CAB7nPqQuMGsgYVnhhN=hW4GD6j4fB9-aTYjHcJqjN0v_-U3ZzA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Mar 18, 2015 at 10:51 AM, Alvaro Herrera
<alvherre(at)2ndquadrant(dot)com> wrote:
> Michael Paquier wrote:
>> On Wed, Mar 18, 2015 at 2:22 AM, Alvaro Herrera wrote:
>
>> > 1. ordered the argument list to vacuum(), hopefully it's more sensible
>> > now.
>>
>> Fine for me.
>
> Actually, why don't we move va_cols to VacuumParams too?
Because AnalyzeStmt assigns it in gram.y. Parameters directly from
VacuumStmt should not be added in Params, at least that's the spirit
of the patch as originally written.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jim Nasby | 2015-03-18 02:45:02 | Re: proposal: searching in array function - array_position |
| Previous Message | Alvaro Herrera | 2015-03-18 01:51:46 | Re: Strange assertion using VACOPT_FREEZE in vacuum.c |