From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
---|---|
To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
Cc: | PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Increasing timeout of poll_query_until for TAP tests |
Date: | 2016-08-03 21:56:56 |
Message-ID: | CAB7nPqQnJ7f20ELH_fvWDghBEfR8xhxMQTng2rTg4OE4L_4ZAw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, Aug 4, 2016 at 2:34 AM, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> wrote:
> Michael Paquier wrote:
>> On Wed, Aug 3, 2016 at 7:21 AM, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> wrote:
>
>> > Why not capture both items in a single select, such as in the attached
>> > patch?
>>
>> Let me test this....
>> [... A while after ...]
>> This looks to work properly. 12 runs in a row have passed.
>
> Okay, applied that way.
>
> BTW, one-line long queries look awful in that perl code. I don't
> propose to change anything now, but I propose that long queries are
> split using here-docs in new code,
>
> $node->safe_psql(<<EQ);
> SELECT foo
> FROM bar
> EQ
Yep, that would be a good idea. I didn't know this grammar existed. Or
use qq() directly.
--
Michael
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2016-08-03 22:06:45 | Re: Cache Hash Index meta page. |
Previous Message | Thomas Munro | 2016-08-03 21:53:16 | Re: [sqlsmith] FailedAssertion("!(k == indices_count)", File: "tsvector_op.c", Line: 511) |