| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Making src/test/ssl more robust |
| Date: | 2015-04-08 12:57:07 |
| Message-ID: | CAB7nPqQivFxnSjPwkyapa8=HTGm0hfDNvdGcM3=hkK6fPT0+Pg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi all,
I noticed two things while looking at the SSL test suite:
1) When running the tests, some logs are generated in client-log, but
this log file has no entry in .gitignore... A patch is attached.
2) cp is used with a wildcard and system_or_bail in ServerSetup.pm:
system_or_bail "cp ssl/server-*.crt '$tempdir'/pgdata";
system_or_bail "cp ssl/server-*.key '$tempdir'/pgdata";
system_or_bail "chmod 0600 '$tempdir'/pgdata/server-*.key";
system_or_bail "cp ssl/root+client_ca.crt '$tempdir'/pgdata";
system_or_bail "cp ssl/root+client.crl '$tempdir'/pgdata";
This does not look very portable to me. Wouldn't it be better to use
glob to get a list of the files and then copy each matching entry?
Thoughts?
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| 20150408_ssl_tap_gitignore.patch | text/x-patch | 202 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Sawada Masahiko | 2015-04-08 13:53:59 | Re: Proposal : REINDEX xxx VERBOSE |
| Previous Message | Andres Freund | 2015-04-08 12:33:39 | Re: Re: File count restriction of directory limits number of relations inside a database. |