Re: Confusing error message with too-large file in pg_basebackup

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
Cc: PostgreSQL Bugs List <pgsql-bugs(at)postgresql(dot)org>, Josh Berkus <josh(at)agliodbs(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: Confusing error message with too-large file in pg_basebackup
Date: 2015-11-20 12:09:41
Message-ID: CAB7nPqQh4QZk=JHr_7xPToWeP=-dFjGyQO7bJAQ6-w6q06qcpg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On Fri, Nov 20, 2015 at 4:39 PM, Guillaume Lelarge wrote:
> Looking at the file's size is probably a better idea.

But isn't that already what the backend does?

> As far as I know,
> PostgreSQL doesn't create files bigger than 1GB, except for log files.

In most cases where the default is used, yes. Now this depends as well
on --with-segsize.

> I'm not sure about this but I guess pg_basebackup doesn't ship log files. So, looking at the size would work.

It does fetch files from pg_log. We actually had on hackers not so
long ago discussions about authorizing some filtering option in
pg_basebackup for partially this purpose.
--
Michael

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Alvaro Herrera 2015-11-20 12:33:59 Re: Confusing error message with too-large file in pg_basebackup
Previous Message Guillaume Lelarge 2015-11-20 07:39:05 Re: Confusing error message with too-large file in pg_basebackup