| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com> |
| Cc: | "Tsunakawa, Takayuki" <tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [bug fix] Savepoint-related statements terminates connection |
| Date: | 2017-05-17 07:26:25 |
| Message-ID: | CAB7nPqQ_upowcgA8teBh3A__+57dDZ+Z+8gmN2Z1XDFLxFPFdQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Mar 31, 2017 at 9:58 PM, Ashutosh Bapat
<ashutosh(dot)bapat(at)enterprisedb(dot)com> wrote:
> Then the question is why not to allow savepoints as well? For that we
> have to fix transaction block state machine.
I agree with this argument. I have been looking at the patch, and what
it does is definitely incorrect. Any query string including multiple
queries sent to the server is executed as a single transaction. So,
while the current behavior of the server is definitely incorrect for
savepoints in this case, the proposed patch does not fix anything but
actually makes things worse. I think that instead of failing,
savepoints should be able to work properly. As you say cursors are
handled correctly, savepoints should fall under the same rules.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tsunakawa, Takayuki | 2017-05-17 07:38:56 | Re: [bug fix] Savepoint-related statements terminates connection |
| Previous Message | Tsunakawa, Takayuki | 2017-05-17 07:06:03 | Re: [bug fix] PG10: libpq doesn't connect to alternative hosts when some errors occur |