From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
---|---|
To: | Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru> |
Cc: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Fix bloom WAL tap test |
Date: | 2017-11-10 00:49:50 |
Message-ID: | CAB7nPqQZKuWvePUvcVGk9F+rjPYxPSPfwrZSE9BztAuxLuEzgA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, Nov 9, 2017 at 7:51 PM, Alexander Korotkov
<a(dot)korotkov(at)postgrespro(dot)ru> wrote:
> On Wed, Nov 8, 2017 at 5:46 AM, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
> wrote:
>> > So I think
>> > that you should instead do something like that:
>> >
>> > --- a/contrib/bloom/Makefile
>> > +++ b/contrib/bloom/Makefile
>> > @@ -20,5 +20,12 @@ include $(top_builddir)/src/Makefile.global
>> > include $(top_srcdir)/contrib/contrib-global.mk
>> > endif
>> >
>> > +installcheck: wal-installcheck
>> > +
>> > +check: wal-check
>> > +
>> > +wal-installcheck:
>> > + $(prove_installcheck)
>> > +
>> > wal-check: temp-install
>> > $(prove_check)
>> >
>> > This works for me as I would expect it should.
>>
>> Looks good to me too.
>
> OK, then so be it :)
Thanks for the new version. This one, as well as the switch to
psql_safe in https://www.postgresql.org/message-id/CAPpHfduxgEYF_0BTs-mxGC4=w5sw8rnUbq9BSTp1Wq7=NwrWDA@mail.gmail.com
are good for a committer lookup IMO.
--
Michael
From | Date | Subject | |
---|---|---|---|
Next Message | Andres Freund | 2017-11-10 00:53:09 | Re: [HACKERS] pgsql: Fix freezing of a dead HOT-updated tuple |
Previous Message | Mark Rofail | 2017-11-10 00:47:04 | Re: GSoC 2017: Foreign Key Arrays |