Re: Fast promotion not used when doing a recovery_target PITR restore?

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Fast promotion not used when doing a recovery_target PITR restore?
Date: 2017-06-22 05:04:42
Message-ID: CAB7nPqQXqHSH4vRxHOFaHvmz2VKvXz=OqtnVFmauqRuPoyL5gA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jun 22, 2017 at 3:04 AM, Andres Freund <andres(at)anarazel(dot)de> wrote:
> When doing a PITR style recovery, with recovery target set, we're
> currently not doing a fast promotion, in contrast to the handling when
> doing a pg_ctl or trigger file based promotion. That can prolong making
> the server available for writes.
>
> I can't really see a reason for this?

Yes, you are right. I see no reason either why this cannot be done.
Why not just switching fast_promote to true in when using
RECOVERY_TARGET_ACTION_PROMOTE? That's a bug, not a critical one
though.
--
Michael

Attachment Content-Type Size
recovery-stop-promote.patch application/octet-stream 370 bytes

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Yugo Nagata 2017-06-22 05:06:24 Re: Logical replication launcher never been restarted when terminated
Previous Message Yugo Nagata 2017-06-22 04:58:38 Re: Autovacuum launcher occurs error when cancelled by SIGINT