Re: BUG #14001: pg_ctl error output empty/faulty

On Sat, Mar 5, 2016 at 9:00 PM, <doublem09(at)googlemail(dot)com> wrote:
> Under Windows 10 error messages don't appear even in the command line (no
> problem for Windows 7 here).
> E.g. typing "pg_ctl status" in a cmd shell yields no output at all.
>
> After a brief test it seems this can be fixed by correcting the negation
> "if (!pgwin32_is_service())" to "if (pgwin32_is_service())" in pg_ctl.c
> write_stderr(...).

Indeed. I don't think that this oversight from a9676139 needs much comment...
--- a/src/bin/pg_ctl/pg_ctl.c
+++ b/src/bin/pg_ctl/pg_ctl.c
@@ -216,7 +216,7 @@ write_stderr(const char *fmt,...)
* On Win32, we print to stderr if running on a console, or write to
* eventlog if running as a service
*/
- if (!isatty(fileno(stderr))) /* Running as a service */
+ if (!pgwin32_is_service()) /* Running as a service */
{
Could somebody switch this condition? We should not write to the event
logs if this code is not run for a service.
--
Michael