| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Vitaly Burovoy <vitaly(dot)burovoy(at)gmail(dot)com>, Oleg Bartunov <obartunov(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Bug in searching path in jsonb_set when walking through JSONB array |
| Date: | 2016-03-24 00:38:22 |
| Message-ID: | CAB7nPqQTD6nGfJnhBadoSx72Vcxejp_3dwGB+hfExh3o_V-umQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Mar 23, 2016 at 11:01 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Michael Paquier <michael(dot)paquier(at)gmail(dot)com> writes:
>> That's ugly. We should actually use TextDatumGetCString because the
>> index is stored as text here via a Datum, and then it is converted
>> back to an integer. So I propose instead the simple patch attached
>> that fixes the failure for me. Could you check if that works for you?
>
> Yeah, this seems better. But that code needs review anyway, as it's using
> elog() for user-facing error conditions, and I'm thinking the error texts
> could use a bit of attention from a native English speaker.
Thanks. The bug fix is 384dfbd, and the improvements of error messages
is ea4b8bd.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2016-03-24 00:39:30 | Re: PoC: Partial sort |
| Previous Message | Andres Freund | 2016-03-24 00:14:25 | Re: Speed up Clog Access by increasing CLOG buffers |