Re: Perf Benchmarking and regression.

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Noah Misch <noah(at)leadboat(dot)com>, Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Mithun Cy <mithun(dot)cy(at)enterprisedb(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Subject: Re: Perf Benchmarking and regression.
Date: 2016-06-10 00:46:17
Message-ID: CAB7nPqQR=4sc+8ycO94Brr4-9TxkwKtmgvKOrWVFO0jq7CHrxQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Jun 10, 2016 at 9:42 AM, Andres Freund <andres(at)anarazel(dot)de> wrote:
> On 2016-06-10 09:41:09 +0900, Michael Paquier wrote:
>> On Fri, Jun 10, 2016 at 9:37 AM, Andres Freund <andres(at)anarazel(dot)de> wrote:
>> > On 2016-06-10 09:34:33 +0900, Michael Paquier wrote:
>> >> On Fri, Jun 10, 2016 at 9:19 AM, Andres Freund <andres(at)anarazel(dot)de> wrote:
>> >> > On 2016-06-09 14:37:31 -0700, Andres Freund wrote:
>> >> >> I'm writing a patch right now, planning to post it later today, commit
>> >> >> it tomorrow.
>> >> >
>> >> > Attached.
>> >>
>> >> - /* see bufmgr.h: OS dependent default */
>> >> - DEFAULT_BACKEND_FLUSH_AFTER, 0, WRITEBACK_MAX_PENDING_FLUSHES,
>> >> + 0, 0, WRITEBACK_MAX_PENDING_FLUSHES,
>> >> Wouldn't it be better to still use LT_BACKEND_FLUSH_AFTER here, and
>> >> just enforce it to 0 for all the OSes at the top of bufmgr.h?
>> >
>> > What would be the point? The only reason for DEFAULT_BACKEND_FLUSH_AFTER
>> > was that it differed between operating systems. Now it doesn't anymore.
>>
>> Then why do you keep it defined?
>
> Ooops. Missing git add.

:)
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Haribabu Kommi 2016-06-10 02:23:54 Re: WIP: Data at rest encryption
Previous Message Andres Freund 2016-06-10 00:42:11 Re: Perf Benchmarking and regression.