Re: GinPageIs* don't actually return a boolean

On Fri, Mar 18, 2016 at 8:36 PM, Yury Zhuravlev
<u(dot)zhuravlev(at)postgrespro(dot)ru> wrote:
> Robert Haas wrote:
>>
>> On Wed, Mar 2, 2016 at 9:48 PM, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:
>>>
>>> On 2/11/16 9:30 PM, Michael Paquier wrote: ...
>>
>>
>> We need to decide what to do about this. I disagree with Peter: I
>> think that regardless of stdbool, what we've got right now is sloppy
>> coding - bad style if nothing else. Furthermore, I think that while C
>> lets you use any non-zero value to represent true, our bool type is
>> supposed to contain only one of those two values. Therefore, I think
>> we should commit the full patch, back-patch it as far as somebody has
>> the energy for, and move on. But regardless, this patch can't keep
>> sitting in the CommitFest - we either have to take it or reject it,
>> and soon.
>>
>
> I know that we are trying to do the right thing. But right now there is an
> error only in ginStepRight. Maybe now the fix this place, and we will think
> about "bool" then? The patch is attached (small and simple).

FWIW, when compiling with MS 2015 using the set of perl scripts I am
not seeing this compilation error... We may want to understand first
what kind of dependency is involved when doing the cmake build
compared to what is done with src/tools/msvc.
--
Michael