| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp> |
| Cc: | Rushabh Lathia <rushabh(dot)lathia(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Noah Misch <noah(at)leadboat(dot)com>, Thom Brown <thom(at)linux(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Albe Laurenz <laurenz(dot)albe(at)wien(dot)gv(dot)at>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Shigeru Hanada <shigeru(dot)hanada(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Optimization for updating foreign tables in Postgres FDW |
| Date: | 2016-04-12 01:45:13 |
| Message-ID: | CAB7nPqQOS81RPa7fvCbQXsLpcZe0+82DzgsaKxZ6-+9Qg9OT9g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Apr 11, 2016 at 5:16 PM, Etsuro Fujita
<fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp> wrote:
> On 2016/04/11 12:30, Michael Paquier wrote:
>>
>> + if ((cancel = PQgetCancel(entry->conn)))
>> + {
>> + PQcancel(cancel, errbuf, sizeof(errbuf));
>> + PQfreeCancel(cancel);
>> + }
>> Wouldn't it be better to issue a WARNING here if PQcancel does not
>> succeed?
>
> Seems like a good idea. Attached is an updated version of the patch.
Thanks for the new version. The patch looks good to me.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Craig Ringer | 2016-04-12 01:54:37 | Re: Some other things about contrib/bloom and generic_xlog.c |
| Previous Message | Craig Ringer | 2016-04-12 00:52:23 | Re: Lets (not) break all the things. Was: [pgsql-advocacy] 9.6 -> 10.0 |