Re: pgsql: pg_rewind: Don't error if the two clusters are already on the sa

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: pg_rewind: Don't error if the two clusters are already on the sa
Date: 2015-12-12 01:44:14
Message-ID: CAB7nPqQNFfkw8Zda3wSLgaz5aVZ2zHhWLpGWJQM_5xvtZROJGA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Sat, Dec 12, 2015 at 9:11 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
>> pg_rewind: Don't error if the two clusters are already on the same timeline
>> This previously resulted in an error and a nonzero exit status, but
>> after discussion this should rather be a noop with a zero exit status.
>
> Hm, if we're going to do that, shouldn't we back-patch the behavior
> change into 9.5 as well?

+1. It would be good to get consistent across branches here.
--
Michael

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2015-12-12 13:30:03 pgsql: Fix ALTER TABLE ... SET TABLESPACE for unlogged relations.
Previous Message Tom Lane 2015-12-12 00:11:05 Re: pgsql: pg_rewind: Don't error if the two clusters are already on the sa

Browse pgsql-hackers by date

  From Date Subject
Next Message Noah Misch 2015-12-12 02:17:12 Re: More on the libxml2 update situation
Previous Message Noah Misch 2015-12-12 01:22:38 Re: Rework the way multixact truncations work