Some messages of pg_rewind --debug not getting translated

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Some messages of pg_rewind --debug not getting translated
Date: 2016-03-22 08:08:16
Message-ID: CAB7nPqQMghiLLA-neYyffg8Y1oBZV6DdqsFHEk34P-MeU2h4SQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi all,

I found that some of the messages generated by pg_rewind --debug are
not getting translated because the string messages are not put within
_(%s). For the debug messages of the file map and the data page map
this is not really a problem because those do not involve any
translatable words like "blk", but for the timeline history file I
think that's a bug. Attached is a patch putting everything under
pg_log(PG_DEBUG) so as we do not rely directly on printf().
Regards,
--
Michael

Attachment Content-Type Size
pg-rewind-debug-fix.patch binary/octet-stream 2.0 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tatsuo Ishii 2016-03-22 08:13:30 Re: multivariate statistics v14
Previous Message Peter Geoghegan 2016-03-22 07:53:31 Re: Missing rows with index scan when collation is not "C" (PostgreSQL 9.5)