From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
---|---|
To: | Sawada Masahiko <sawada(dot)mshk(at)gmail(dot)com> |
Cc: | Petr Jelinek <petr(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Set new system identifier using pg_resetxlog |
Date: | 2014-06-26 00:31:29 |
Message-ID: | CAB7nPqQJS+10T8RdxmLU5C-NafZ0KxQQBYyrnxwuY7ECRwggRQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, Jun 26, 2014 at 2:43 AM, Sawada Masahiko <sawada(dot)mshk(at)gmail(dot)com>
wrote:
> Hi,
>
> I send you review comment about thie patch.
>
> I found no error/warning with compling and installation.
> I have executed pg_resetxlog with some input pattern.
>
> $ initdb -D data -E UTF8 --no-locale
> $ pg_controldata data | grep "Database system identifier"
> Database system identifier: 6028907917695471865
>
> --
> $ pg_resetxlog -s -n data | grep "Database system identifier"
> Database system identifier: 6028907917695471865
>
> The -s option does not works fine with -n option.
>
> --
> $ pg_resetxlog
> -s6028907917695471865111111111111111111111111111111111111111111111111111111
> data
> Transaction log reset
> $ pg_controldata data | grep "Database system identifier"
> Database system identifier: 18446744073709551615
>
> pg_resetxlog is finished successfully, but system identifier was not
> changed.
> Also I think that checking data about number of digits is needed.
>
Yep, system_identifier is a uint64, and the input you are giving here is
incompatible with that.
--
Michael
From | Date | Subject | |
---|---|---|---|
Next Message | tim_wilson | 2014-06-26 00:42:51 | Re: Inaccuracy in VACUUM's tuple count estimates |
Previous Message | Robert Haas | 2014-06-26 00:22:31 | Re: better atomics - v0.5 |