Re: relkind check in info.c

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: PostgreSQL mailing lists <pgsql-odbc(at)postgresql(dot)org>
Subject: Re: relkind check in info.c
Date: 2014-03-18 23:17:26
Message-ID: CAB7nPqQHpm9AuCLj+tjuBdm9Obz08XvKP5261Unio7M1qdgNQA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-odbc

On Wed, Mar 19, 2014 at 8:07 AM, Michael Paquier
<michael(dot)paquier(at)gmail(dot)com> wrote:
> On Wed, Mar 19, 2014 at 3:39 AM, Alvaro Herrera
> <alvherre(at)2ndquadrant(dot)com> wrote:
>> Hi,
>>
>> I see that PGAPI_Tables() has a relkind check that only seems to include
>> tables and views. Does it make sense to have it consider materialized
>> views as well?
>>
>> I don't know anything about psqlodbc -- I'm just going by a question in
>> the spanish list:
>> http://www.postgresql.org/message-id/53287159.7040009@gmail.com
>
> Yeah, it would make sense to list it by adding 'm' to the relkind
> queries. I am noting as well that we should list it when invocating
> SQL_ALL_TABLE_TYPES. A patch to do that is simple, and not worth an
> additional regression test IMO, just to avoid the pain to have
> version-related regression tests...
Just adding that a similar thing should be done with foreign tables.
--
Michael

In response to

Responses

Browse pgsql-odbc by date

  From Date Subject
Next Message Michael Paquier 2014-03-19 12:27:02 Regression tests for deprecated functions
Previous Message Michael Paquier 2014-03-18 23:07:52 Re: relkind check in info.c