Re: [BUGS] BUG #14155: bloom index error with unlogged table

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, Teodor Sigaev <teodor(at)sigaev(dot)ru>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [BUGS] BUG #14155: bloom index error with unlogged table
Date: 2016-06-03 06:11:59
Message-ID: CAB7nPqQH0A9-Vi9iykupjdXBqVVswC0NMQy39DB=e6VK0XBa1w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

On Fri, Jun 3, 2016 at 1:03 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> I wrote:
>> Jeff Janes <jeff(dot)janes(at)gmail(dot)com> writes:
>>> My biggest gripe with it at the moment is that the signature size should be
>>> expressed in bits, and then internally rounded up to a multiple of 16,
>>> rather than having it be expressed in 'uint16'.
>>> If that were done it would be easier to fix the documentation to be more
>>> understandable.
>
>> +1 ... that sort of definition seems much more future-proof, too.
>> IMO it's not too late to change this. (We probably don't want to change
>> the on-disk representation of the reloptions, but we could convert from
>> bits to words in bloptions().)
>
> There were no objections to this, but also no action. Attached is a draft
> patch ... any complaints?

None. This looks rather sane to me.
--
Michael

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Michael Paquier 2016-06-03 06:17:57 Re: [BUGS] BUG #14155: bloom index error with unlogged table
Previous Message Tom Lane 2016-06-03 04:03:00 Re: [BUGS] BUG #14155: bloom index error with unlogged table

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2016-06-03 06:17:57 Re: [BUGS] BUG #14155: bloom index error with unlogged table
Previous Message Andres Freund 2016-06-03 06:09:22 Re: Perf Benchmarking and regression.