| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>, Stephen Frost <sfrost(at)snowman(dot)net>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Magnus Hagander <magnus(at)hagander(dot)net> |
| Subject: | Re: Renaming more clearly SHA functions in pgcrypto/ |
| Date: | 2016-07-05 05:06:46 |
| Message-ID: | CAB7nPqQFOf_p1W7v+A=zavM2HkzVHhewX_YNOtivMPLVMjqiHg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jul 5, 2016 at 2:09 AM, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> wrote:
> Michael Paquier wrote:
>> Hi all,
>> (folks interested in that in CC)
>>
>> While looking at some facility in pgcrypto, I have noticed the stanza
>> created by 56f4478 to prevent conflicts with OpenSSL, like that:
>> +#define SHA256_Init pg_SHA256_Init
>> +#define SHA256_Update pg_SHA256_Update
>>
>> Wouldn't it be better to avoid that, and just rename all those
>> functions as pg_shaXX_foo?
>
> Sure.
OK, so I guess I'll get something into a shape like that.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2016-07-05 08:06:11 | Re: Password identifiers, protocol aging and SCRAM protocol |
| Previous Message | Amit Langote | 2016-07-05 04:48:10 | Re: Declarative partitioning |