Re: [PATCH] Rename pg_switch_xlog to pg_switch_wal

On Tue, Jan 10, 2017 at 1:53 AM, Vladimir Rusinov <vrusinov(at)google(dot)com> wrote:
>
> On Mon, Jan 9, 2017 at 4:14 PM, Peter Eisentraut
> <peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:
>>
>> > pg_is_xlog_replay_paused | pg_is_recovery_paused
>>
>> All the other xlog_replay names have been changed to wal_replay, so
>> making this one different is probably not so good.
>
> Oops, forgot about that one. Attached patch with this addressed as well.

- errhint("pg_xlogfile_name_offset() cannot be executed
during recovery.")));
+ errhint(
+ "pg_wal_file_name_offset() cannot be executed
during recovery.")));
I am not sure that there is any need to reformat this error hint.

Your patch includes useless diff noise in pg_proc.h. By that I mean
the lines of pg_start_backup, pg_stop_backup, etc.

+/* Next OID: 6016 */
+
I don't think you need that.

src/test/perl/PostgresNode.pm has added recently a new method called
lsn() that uses some of the WAL position functions. Their update is
necessary as well for this patch.

As there are two school of thoughts on this thread, keeping your patch
with the compatibility table is the best move for now. Even if we end
up by having a version without aliases, that will be just code to
remove in the final version.
--
Michael