| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Stephen Frost <sfrost(at)snowman(dot)net> |
| Cc: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Remove superuser() checks from pgstattuple |
| Date: | 2016-09-27 06:27:42 |
| Message-ID: | CAB7nPqQApXJ+kPK2sHfyFYXLhZ2P+x0k=bwDFjUr1CudL34-=Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Sep 27, 2016 at 4:43 AM, Stephen Frost <sfrost(at)snowman(dot)net> wrote:
> * Peter Eisentraut (peter(dot)eisentraut(at)2ndquadrant(dot)com) wrote:
>> This is now being obsoleted by the later idea of allowing base installs
>> from a chain of upgrade scripts. But if your upgrade scripts contain
>> ALTER TABLE commands, you will probably still want to write base install
>> scripts that do a fresh CREATE TABLE instead.
>
> I've updated the patch to remove the new base version script and to rely
> on the changes made by Tom to install the 1.4 version and then upgrade
> to 1.5.
>
> Based on my testing, it appears to all work correctly.
Same conclusion from here.
> Updated (much smaller) patch attached.
I had a look at it, and it is doing the work it claims to do. So I am
marking it as "Ready for Committer".
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Craig Ringer | 2016-09-27 06:28:56 | Re: Requesting some information about the small portion of source code of postgreSQL |
| Previous Message | Srinivas Karthik V | 2016-09-27 06:13:43 | Requesting some information about the small portion of source code of postgreSQL |