Re: Fix Error Message for allocate_recordbuf() Failure

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Shoaib Lari <slari(at)pivotal(dot)io>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Fix Error Message for allocate_recordbuf() Failure
Date: 2016-09-21 02:28:13
Message-ID: CAB7nPqQA7=mgXdMNrQOZ8c7LcmqJ8j5HE_8WojWD+=bnUgtFbg@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Sep 21, 2016 at 10:25 AM, Michael Paquier
<michael(dot)paquier(at)gmail(dot)com> wrote:
> On Wed, Sep 21, 2016 at 12:32 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> For what it's worth, I think it's fine. Good error messages are a useful thing.
>>
>> More generally, I think the whole patch looks good and should be committed.
>
> Hm. I'd think that it is still more portable to just issue a WARNING
> message in palloc_extended() when MCXT_ALLOC_NO_OOM then. Other code
> paths could benefit from that as well, and the patch proposed does
> nothing for the other places calling it. I am fine to write a patch
> for this purpose if you agree on that.

Or in short the attached. All the other callers of palloc_extended
benefit from that.
--
Michael

Attachment Content-Type Size
palloc-oom-warning.patch text/plain 973 bytes

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Dilip Kumar 2016-09-21 03:17:52 Re: Speed up Clog Access by increasing CLOG buffers
Previous Message Haribabu Kommi 2016-09-21 02:23:02 Re: New SQL counter statistics view (pg_stat_sql)