| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Don'st start streaming after creating a slot in pg_receivexlog |
| Date: | 2015-07-30 08:14:16 |
| Message-ID: | CAB7nPqQ9qEtuDiKY3OpNzHcz5iUA+DUX9FcN9K8GUkCZvG7+Ew@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jul 29, 2015 at 10:20 PM, Andres Freund <andres(at)anarazel(dot)de> wrote:
> On 2015-07-29 22:17:27 +0900, Michael Paquier wrote:
>> Here is a patch implementing those things. IMO if-not-exists does not
>> make much sense anymore
>
> What? It's rather useful to be able to discern between 'slot was already
> there' and 'oops, some error occured'. -1
OK, fine.
> To me the pg_recvlogical changes are pretty pointless.
OK, you wrote it after all. I won't insist on it. So, perhaps the
attached is more convincing then? It just changes --create-slot to
leave immediately after creation to address the complain of this
thread.
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| 20150730_pgrecv_slots_v2.patch | binary/octet-stream | 1.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2015-07-30 08:21:58 | Re: multivariate statistics / patch v7 |
| Previous Message | Heikki Linnakangas | 2015-07-30 07:00:11 | Re: Using quicksort and a merge step to significantly improve on tuplesort's single run "external sort" |