Re: Handling dropped attributes in pglogical_proto

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Konstantin Knizhnik <k(dot)knizhnik(at)postgrespro(dot)ru>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Handling dropped attributes in pglogical_proto
Date: 2016-09-29 03:33:39
Message-ID: CAB7nPqQ9EzcAE+DHG3b-SvDxxDtDXXpnB4H0pq7fKGpUVO-B5g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Sep 28, 2016 at 11:25 PM, Konstantin Knizhnik
<k(dot)knizhnik(at)postgrespro(dot)ru> wrote:
> But if table was just altered and some attribute was removed from the table,
> then rel->natts can be greater than natts.

This is part of pglogical, so you may want to reply on the dedicated
thread or send directly a patch to them. By the way, this code path
may need to care as well about attisdropped. It is never good not to
check for it.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2016-09-29 03:48:07 Re: Password identifiers, protocol aging and SCRAM protocol
Previous Message Craig Ringer 2016-09-29 03:12:52 Re: Add support for restrictive RLS policies