Re: Missing file versions for a bunch of dll/exe files in Windows builds

From: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
To: Noah Misch <noah(at)leadboat(dot)com>
Cc: MauMau <maumau307(at)gmail(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, pgsql-bugs <pgsql-bugs(at)postgresql(dot)org>
Subject: Re: Missing file versions for a bunch of dll/exe files in Windows builds
Date: 2014-07-12 06:14:54
Message-ID: CAB7nPqQ9D78y6qfXiNwYc92oT2YHK-i6GTkLaMadewzYUHPS9Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

On Fri, Jul 11, 2014 at 10:34 PM, Noah Misch <noah(at)leadboat(dot)com> wrote:
> Please fix the MODULES case, perhaps by linking $(WIN32RES) into each library
> implicitly.
Yes, that's exactly what I did in the patch attached by linking
WIN32RES and a shared library when the lib is built from a single .o
file. The rule in src/makefiles/Makefile.win32 has been updated
accordingly. pgxs.mk has been updated as well to remove WIN32RES when
clean is invoked for MODULES.
--
Michael

Attachment Content-Type Size
0001-MSVC-Recognize-PGFILEDESC-in-contrib-and-conversion_.patch text/x-patch 4.1 KB
0002-Improve-versioning-for-MSVC-and-MinGW-builds.patch text/x-patch 50.1 KB

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Michael Paquier 2014-07-12 06:51:59 Re: BUG #10925: Documentation not clear on copy options containing '_'
Previous Message Tom Lane 2014-07-11 21:49:14 Re: BUG #10922: row_to_json creates invalid JSON for currecy lower then 1000.