From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
---|---|
To: | Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru> |
Cc: | Fabrízio Mello <fabriziomello(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Fix bloom WAL tap test |
Date: | 2017-11-08 02:01:32 |
Message-ID: | CAB7nPqQ50n8s8YAWACiCq5aiZx-8uV4bTaYBwVQRXBLcWzUhXg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Nov 8, 2017 at 1:49 AM, Alexander Korotkov
<a(dot)korotkov(at)postgrespro(dot)ru> wrote:
> On Tue, Nov 7, 2017 at 4:26 PM, Fabrízio Mello <fabriziomello(at)gmail(dot)com>
> wrote:
>> The patch doesn't apply against master:
>>
>> fabrizio(at)macanudo:/d/postgresql (master)
>> $ git apply /tmp/wal-check-on-bloom-check.patch
>> error: contrib/bloom/Makefile: already exists in working directory
>
> Apparently I sent patches whose are ok for "patch -p1", but not ok for "git
> apply".
> Sorry for that. I resubmit both of them.
I would not worry about that as long as there is a way to apply
patches. git apply fails to easily to be honest, while patch -p1 is
more permissive. I use the latter extensively by the way, because it
has the merit to not be a PITA.
--
Michael
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Eisentraut | 2017-11-08 02:15:08 | pgsql: Expand empty end tag |
Previous Message | Michael Paquier | 2017-11-08 01:46:43 | Re: Remove duplicate setting in test/recovery/Makefile |